Stricter return type for makeValidator #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimenB
approved these changes
Dec 24, 2019
|
👍 thanks! |
tuannm151
pushed a commit
to BSSCommerce/shopify-envalid
that referenced
this pull request
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the return type for
makeValidatorstricter, helping to ensure that you're returning a value from the validator that at least looks right.The caveat here is that
JSON.parsereturnsany, so if that's your first step you'll have to use something like a user-defined typeguard (seeisArrayOfStringshelper added to test file) to further refine the type if you want TS to catch anything. But this should still help if, say, you writemakeValidator<number>(....)and try toreturn new Date(....)at the end of it.