commitsar does not need to be in the same folder as the repository #93
Comments
|
Issue Label Bot is not confident enough to auto-label this issue. See dashboard for more details. |
|
@D-Nice Sorry I overlooked this. I will update the readme. It needs improvements in general :) |
fallion
added a commit
that referenced
this issue
Sep 11, 2019
- removes false claim that the binary needs to be in same folder as git repository - adds example usage with Github actions Closes #93
Merged
fallion
added a commit
that referenced
this issue
Sep 11, 2019
- removes false claim that the binary needs to be in same folder as git repository - adds example usage with Github actions Closes #93
fallion
added a commit
that referenced
this issue
Sep 11, 2019
- removes false claim that the binary needs to be in same folder as git repository - adds example usage with Github actions Closes #93
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
From my testing, of at least the latest current container (digest 195395165b624550f4d9100407b6d1207369cc843c74d0eb7b6d7a7d2c089a0c) the bolded statement in the readme doesn't hold true, which is a good thing. I believe just the current dir needs to be the repository you wish commitsar to test.
I run it in the following configuration:
$ docker run -v "$PWD":/wd -w /wd --rm --entrypoint /app/commitsar fallion/commitsarfrom the repository I want tested.
I was also going to recommend changing the entrypoint from
./commitsarwhich is why I need the entrypoint override, but I see that has been done already.The text was updated successfully, but these errors were encountered: