Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make revert commit generated by git CLI compliant #434

Closed
halafi opened this issue Nov 25, 2021 · 0 comments · Fixed by #440
Closed

Make revert commit generated by git CLI compliant #434

halafi opened this issue Nov 25, 2021 · 0 comments · Fixed by #440
Assignees
@fallion
Labels
bug Something isn't working standard-compliance For issues that have desync with conventional commit standard

Comments

@halafi
Copy link

halafi commented Nov 25, 2021

it's similar exception as when doing git merge: https://git-scm.com/docs/git-revert, alternatively it could be done with edit message param git revert -e

the default message is Revert "..."
@fallion fallion self-assigned this Nov 25, 2021
@fallion fallion added bug Something isn't working standard-compliance For issues that have desync with conventional commit standard labels Nov 25, 2021
fallion added a commit that referenced this issue Dec 31, 2021
@fallion
feat: allow revert commits
2c0a325 
Previously Revert commits would fail the pipeline as they were not considered conventional commit friendly.
This caused issues in multiple projects as commitsar checks would just be ignored.

Closes #434
@fallion fallion mentioned this issue Dec 31, 2021
Merged
fallion added a commit that referenced this issue Dec 31, 2021
@fallion
feat: allow revert commits
159cec8 
Previously Revert commits would fail the pipeline as they were not considered conventional commit friendly.
This caused issues in multiple projects as commitsar checks would just be ignored.

Closes #434
@fcanovai fcanovai mentioned this issue Jun 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fallion fallion

Labels
bug Something isn't working standard-compliance For issues that have desync with conventional commit standard
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: allow revert commits aevea/commitsar
2 participants
@fallion @halafi