Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

With Commits Disabled PR Title Is Not Checked #296

Closed
fargozhu opened this issue Aug 29, 2020 · 5 comments · Fixed by #426
Closed

With Commits Disabled PR Title Is Not Checked #296

fargozhu opened this issue Aug 29, 2020 · 5 comments · Fixed by #426
Assignees
@fallion

Comments

@fargozhu
Copy link

When disabling PR commits

commits:
  disabled: false

the github action doesn't checks anything and leaves with a message

Commit section skipped due to commits.disabled set to true in .commitsar.yaml

when the expectation was to validate only the PR title.
@fallion
Copy link
Member

fallion commented Aug 29, 2020

Going to check this and make a test for this :) Thanks for reporting it.

@fallion
Copy link
Member

fallion commented Aug 29, 2020

Are you aiming to use the JIRA PR check?

@fargozhu
Copy link
Author

@fallion not planning...

@fallion
Copy link
Member

fallion commented Aug 31, 2020

@fargozhu So conventional commit style but for PR title?

@fallion
Copy link
Member

fallion commented Sep 24, 2020

@fargozhu sorry didn't get notification for the thumbs up. Will fix it 👍

@fallion fallion self-assigned this Oct 10, 2021
fallion added a commit that referenced this issue Oct 11, 2021
@fallion
feat: add support for conventional commit style PR titles
3bff483 
This commit adds support for checking that a PR title is conventional commit style compliant.

Closes #296
@fallion fallion mentioned this issue Oct 11, 2021
Merged
fallion added a commit that referenced this issue Oct 11, 2021
@fallion
feat: add support for conventional commit style PR titles
5782852 
This commit adds support for checking that a PR title is conventional commit style compliant.

Closes #296
fallion added a commit that referenced this issue Oct 11, 2021
@fallion
feat: add support for conventional commit style PR titles
08545fd 
This commit adds support for checking that a PR title is conventional commit style compliant.

Closes #296
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fallion fallion

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add support for conventional commit style PR titles aevea/commitsar
2 participants
@fallion @fargozhu