Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make <p> tags optional #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

WattyRev
Copy link

@WattyRev WattyRev commented Jun 2, 2016

Hey there,

I'd like to use this addon, but I don't necessarily want it to add p tags all the time. I modified it to make the p tags optional.

@givanse
Copy link
Member

givanse commented Jun 2, 2016

cool ty, will merge when CI goes green

@ghost
Copy link

ghost commented Jun 3, 2016

Hmm, not sure what's up with that failure. Not sure how my changes would cause a timeout..

@givanse
Copy link
Member

givanse commented Jun 3, 2016

Are the tests passing locally? My guess is not. ember try:testall

@ghost
Copy link

ghost commented Jun 3, 2016

This is the kind of error that I get:

For scenario ember-canary, using:
Versions do not match: Expected: components/ember#canary but saw 2.7.0-canary+c65f57ce This might be ok, depending on the scenario
  ember 2.7.0-canary+c65f57ce
Future versions of Ember CLI will not support v5.10.1. Please update to Node 0.12 or io.js.
version: 0.2.5

A new version of ember-cli is available (2.5.1). To install it, type ember update.
Build failed.
ENOENT: no such file or directory, scandir 'node_modules/ember-cli-ic-ajax/node_modules/'
Error: ENOENT: no such file or directory, scandir 'node_modules/ember-cli-ic-ajax/node_modules/'
    at Error (native)
    at Object.fs.readdirSync (fs.js:856:18)
    at /Users/swatson/ember-cli-lorem-ipsum/node_modules/ember-cli/node_modules/broccoli-merge-trees/index.js:32:21
    at Array.map (native)
    at mergeRelativePath (/Users/swatson/ember-cli-lorem-ipsum/node_modules/ember-cli/node_modules/broccoli-merge-trees/index.js:30:29)
    at /Users/swatson/ember-cli-lorem-ipsum/node_modules/ember-cli/node_modules/broccoli-merge-trees/index.js:23:5
    at lib$rsvp$$internal$$tryCatch (/Users/swatson/ember-cli-lorem-ipsum/node_modules/rsvp/dist/rsvp.js:1036:16)
    at lib$rsvp$$internal$$invokeCallback (/Users/swatson/ember-cli-lorem-ipsum/node_modules/rsvp/dist/rsvp.js:1048:17)
    at lib$rsvp$$internal$$publish (/Users/swatson/ember-cli-lorem-ipsum/node_modules/rsvp/dist/rsvp.js:1019:11)
    at lib$rsvp$asap$$flush (/Users/swatson/ember-cli-lorem-ipsum/node_modules/rsvp/dist/rsvp.js:1198:9)

Looks like an issue with being in a fork and with npm install missing some stuff... Not sure what there is for me to do about it.

@givanse
Copy link
Member

givanse commented Jun 3, 2016

The ember-try config is pulling a version newer than expected.
https://github.com/ember-cli/ember-try

That is understandable, since the config:
https://github.com/aethermx/ember-cli-lorem-ipsum/blob/master/config/ember-try.js
just lists ember#try

For:

ENOENT: no such file or directory, scandir 'node_modules/ember-cli-ic-ajax/node_modules/'

This addon was built with an ember-cli version way older than the one that you are using, that is why that package is missing.

Upgrading ember-cli should be fairly straight forward if you don't mind doing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants