-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make <p> tags optional #1
base: master
Are you sure you want to change the base?
Conversation
cool ty, will merge when CI goes green |
Hmm, not sure what's up with that failure. Not sure how my changes would cause a timeout.. |
Are the tests passing locally? My guess is not. |
This is the kind of error that I get:
Looks like an issue with being in a fork and with npm install missing some stuff... Not sure what there is for me to do about it. |
The ember-try config is pulling a version newer than expected. That is understandable, since the config: For:
This addon was built with an ember-cli version way older than the one that you are using, that is why that package is missing. Upgrading ember-cli should be fairly straight forward if you don't mind doing it. |
Hey there,
I'd like to use this addon, but I don't necessarily want it to add p tags all the time. I modified it to make the p tags optional.