Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update sdk to 13.3.2 #17

Merged
merged 1 commit into from
May 4, 2024
Merged

build: update sdk to 13.3.2 #17

merged 1 commit into from
May 4, 2024

Conversation

CedrikNikita
Copy link
Collaborator

No description provided.

Copy link
Contributor

github-actions bot commented May 3, 2024

@davidyuk
Copy link
Member

davidyuk commented May 4, 2024

I propose a patch:

@@ -130,6 +130,9 @@ const cleanDB = async () => {
   await Tx.sync({ force: true });
 };
 
+// TODO: don't validate hash or accept fee, gasPrice provided by wallet
+const GA_META_PARAMS = { fee: 1e14, gasPrice: 1e9 };
+
 const createTransaction = async (hash, tx) => {
   try {
     unpackTx(tx);
@@ -138,7 +141,9 @@ const createTransaction = async (hash, tx) => {
     throw new TxUnpackFailedError();
   }
 
-  const computedHash = Buffer.from(await buildAuthTxHash(tx, { onNode: node })).toString('hex');
+  const computedHash = (
+    await buildAuthTxHash(tx, { onNode: node, ...GA_META_PARAMS })
+  ).toString('hex');
   if (computedHash !== hash) throw new TxHashNotMatchingError();

@CedrikNikita CedrikNikita requested a review from davidyuk May 4, 2024 11:20
@CedrikNikita CedrikNikita marked this pull request as ready for review May 4, 2024 11:20
@CedrikNikita CedrikNikita reopened this May 4, 2024
@CedrikNikita CedrikNikita merged commit 0669ea3 into main May 4, 2024
2 of 4 checks passed
@CedrikNikita CedrikNikita deleted the feature/update-sdk branch October 19, 2024 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants