Prepare v7.4.0 #124
Merged
Prepare v7.4.0 #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thepiwo
approved these changes
Jul 6, 2023
thepiwo
reviewed
Jul 6, 2023
| ``` | ||
|
|
||
| ``` | ||
| curl http://localhost:3080/api-version | ||
|
|
||
| {"api-version":"7.2.0"} | ||
| {"api-version":"7.3.0"} |
There was a problem hiding this comment.
we just forgot to count that up in 7.3.0? maybe its a good time to make at least this in sync with the released version
There was a problem hiding this comment.
Nah, let's keep it this way. If there is an update to just the compiler we'd still have to bump the version of the HTTP-compiler but it would be wrong to bump the API version, right?
There was a problem hiding this comment.
maybe we should so http-compiler version == api-version and if there is a breaking api change also consider it a breaking http compiler change, so the http compiler is the api
uwiger
approved these changes
Jul 6, 2023
ghallak
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is supported by the Æternity Crypto Foundation