Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(index): Include amountFormatter and SCHEMA in bundle #936

Merged
merged 6 commits into from
Mar 12, 2020

Conversation

nduchak
Copy link
Contributor

@nduchak nduchak commented Mar 10, 2020

No description provided.

@nduchak nduchak self-assigned this Mar 10, 2020
@lgtm-com
Copy link

lgtm-com bot commented Mar 10, 2020

This pull request introduces 1 alert when merging 03bebe4 into b5e403f - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@codecov
Copy link

codecov bot commented Mar 10, 2020

Codecov Report

Merging #936 into develop will decrease coverage by 0.23%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #936      +/-   ##
===========================================
- Coverage    92.93%   92.69%   -0.24%     
===========================================
  Files           57       57              
  Lines         2928     2930       +2     
===========================================
- Hits          2721     2716       -5     
- Misses         207      214       +7     
Impacted Files Coverage Δ
es/index.js 100.00% <100.00%> (ø)
es/utils/json-big.js 81.25% <0.00%> (-2.89%) ⬇️
es/channel/internal.js 95.31% <0.00%> (-0.79%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e30d1a2...d2988d8. Read the comment docs.

@mradkov mradkov self-requested a review March 12, 2020 08:54
@nduchak nduchak merged commit 19d68d9 into develop Mar 12, 2020
@nduchak nduchak deleted the docs/adjust-guide branch March 12, 2020 13:02
@nduchak nduchak mentioned this pull request Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants