Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(AmountFormatter): Change formatter units naming. Add more units #909

Merged
merged 3 commits into from
Feb 20, 2020

Conversation

nduchak
Copy link
Contributor

@nduchak nduchak commented Feb 19, 2020

Extend balance and getBalance Chain methods with amount-formatter

Adjust test's
Extend `balance` and `getBalance` Chain methods with amount-formatter
@codecov
Copy link

codecov bot commented Feb 19, 2020

Codecov Report

Merging #909 into develop will decrease coverage by 27.13%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop     #909       +/-   ##
============================================
- Coverage    92.70%   65.57%   -27.14%     
============================================
  Files           57       43       -14     
  Lines         2935     2379      -556     
============================================
- Hits          2721     1560     -1161     
- Misses         214      819      +605     
Impacted Files Coverage Δ
es/contract/aci/transformation.js 5.42% <0.00%> (-89.76%) ⬇️
es/ae/oracle.js 9.61% <0.00%> (-88.47%) ⬇️
es/contract/aci/helpers.js 12.90% <0.00%> (-87.10%) ⬇️
es/utils/mptree.js 3.92% <0.00%> (-76.48%) ⬇️
es/ae/contract.js 19.40% <0.00%> (-76.12%) ⬇️
es/contract/ga/index.js 30.43% <0.00%> (-69.57%) ⬇️
es/contract/aci/index.js 28.26% <0.00%> (-67.40%) ⬇️
es/utils/string.js 40.00% <0.00%> (-60.00%) ⬇️
es/utils/bytes.js 45.83% <0.00%> (-54.17%) ⬇️
es/oracle/node.js 50.00% <0.00%> (-50.00%) ⬇️
... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc739b4...6395497. Read the comment docs.

@nduchak nduchak force-pushed the feat/amount-formatter-improvements branch from 06ae325 to 6395497 Compare February 20, 2020 10:27
@nduchak nduchak requested a review from mradkov February 20, 2020 11:12
@nduchak nduchak merged commit 6970efe into develop Feb 20, 2020
@nduchak nduchak deleted the feat/amount-formatter-improvements branch February 20, 2020 12:23
@nduchak nduchak mentioned this pull request Feb 25, 2020
@mradkov mradkov mentioned this pull request Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants