feat(TxBuilder): Integrate amount formatter to transaction builder #897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `toAettos` to `amount-formatter` Add `denomination` options to each high lvl API which use TxBuilder(default: 'aettos') Adjust `bignumber` helper documentation Add test's
|
closes #382 |
Codecov Report
@@ Coverage Diff @@
## develop #897 +/- ##
============================================
+ Coverage 79.97% 92.67% +12.69%
============================================
Files 57 57
Lines 2902 2923 +21
============================================
+ Hits 2321 2709 +388
+ Misses 581 214 -367
Continue to review full report at Codecov.
|
…lder' into feat/amount-formatter-for-tx-builder
mradkov
reviewed
Feb 13, 2020
nduchak
force-pushed
the
feat/amount-formatter-for-tx-builder
branch
from
e613848
to
fd31fbd
Compare
nduchak
force-pushed
the
feat/amount-formatter-for-tx-builder
branch
from
b092f94
to
75bc3fc
Compare
mradkov
approved these changes
Feb 19, 2020
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
toAettostoamount-formatterAdd
denominationoptions to each high lvl API which use TxBuilder(default: 'aettos')Adjust
bignumberhelper documentationAdd test's