Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(network): Throw error when can not get networkId #863

Merged
merged 9 commits into from
Jan 22, 2020
Merged

feat(network): Throw error when can not get networkId #863

merged 9 commits into from
Jan 22, 2020

Conversation

nduchak
Copy link
Contributor

@nduchak nduchak commented Jan 16, 2020

No description provided.

@nduchak nduchak added the enhancement New feature or request label Jan 16, 2020
@nduchak nduchak self-assigned this Jan 16, 2020
@nduchak
Copy link
Contributor Author

nduchak commented Jan 16, 2020

Resolve #862

@lgtm-com
Copy link

lgtm-com bot commented Jan 16, 2020

This pull request introduces 2 alerts when merging f1f27f5 into 199d2b3 - view on LGTM.com

new alerts:

  • 2 for Unused variable, import, function or class

@nduchak nduchak force-pushed the feature/throw-error-in-networl-is-not-provided branch from f1f27f5 to 08c9689 Compare January 16, 2020 15:32
@lgtm-com
Copy link

lgtm-com bot commented Jan 16, 2020

This pull request introduces 1 alert when merging 08c9689 into 199d2b3 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@nduchak nduchak force-pushed the feature/throw-error-in-networl-is-not-provided branch from 08c9689 to 873d21b Compare January 16, 2020 15:43
@codecov
Copy link

codecov bot commented Jan 16, 2020 •
edited
Loading

Codecov Report

Merging #863 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           develop   #863   +/-   ##
======================================
  Coverage       93%    93%           
======================================
  Files           57     57           
  Lines         2830   2830           
======================================
  Hits          2632   2632           
  Misses         198    198

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d09e02...3f6e766. Read the comment docs.

@nduchak nduchak merged commit 41b7bd1 into develop Jan 22, 2020
@nduchak nduchak deleted the feature/throw-error-in-networl-is-not-provided branch January 22, 2020 14:07
@nduchak nduchak mentioned this pull request Jan 31, 2020
Merged
@mradkov mradkov mentioned this pull request Jun 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shekhar-shubhendu shekhar-shubhendu shekhar-shubhendu approved these changes

Assignees

@nduchak nduchak

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nduchak @shekhar-shubhendu