Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ACI): Refactor ACI module #505

Merged
merged 38 commits into from
Jun 22, 2019
Merged

feat(ACI): Refactor ACI module #505

merged 38 commits into from
Jun 22, 2019

Conversation

nduchak
Copy link
Contributor

@nduchak nduchak commented Jun 22, 2019

No description provided.

nduchak and others added 30 commits June 3, 2019 16:08
…`decode` method in contract low

Make ACI `call` function decode result imediatly. Fix all contract tests.

BREAKING CHANGE: Change Contract low lvl API: change `contractDecodeData` interface from `(type:
String, data: String) => Any` to `(source: String, fn: String, callValue: String, callResult:
String) => Any`. * `callResult` is `callType` from call result, be `ok`, `revert`, ...

#458
@nduchak nduchak added the enhancement New feature or request label Jun 22, 2019
@nduchak nduchak added this to the Sprint 42 milestone Jun 22, 2019
@nduchak nduchak requested a review from ricricucit June 22, 2019 10:25
@nduchak nduchak self-assigned this Jun 22, 2019
Copy link
Contributor

@ricricucit ricricucit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nduchak nduchak merged commit fb7bc00 into develop Jun 22, 2019
@nduchak nduchak deleted the feature/aci-refactoring branch June 23, 2019 19:15
This was referenced Jun 24, 2019
@mradkov mradkov mentioned this pull request Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants