Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid usage of semver package #378

Merged
merged 6 commits into from
May 10, 2019
Merged

Avoid usage of semver package #378

merged 6 commits into from
May 10, 2019

Conversation

davidyuk
Copy link
Member

@davidyuk davidyuk commented May 6, 2019

I think semver package is too heavy to use it for checking of the version of Epoch node. I propose to write a custom check function. This is how the bundle size changes after it:

Filename Size before Size after
aepp-sdk.browser.js 466K 451K
aepp-sdk.js 445K 430K

ricricucit
ricricucit approved these changes May 10, 2019
View reviewed changes
Copy link
Contributor

@ricricucit ricricucit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐦

@ricricucit ricricucit merged commit dbb1ba0 into develop May 10, 2019
@ricricucit ricricucit deleted the feature/drop-semver-package branch May 10, 2019 14:48
@davidyuk davidyuk mentioned this pull request May 21, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nduchak nduchak nduchak approved these changes

@ricricucit ricricucit ricricucit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidyuk @ricricucit @nduchak