Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use external version of json-bigint #1033

Merged
merged 1 commit into from
Jul 2, 2020

Conversation

davidyuk
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Jun 17, 2020

Codecov Report

Merging #1033 into develop will increase coverage by 0.85%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1033      +/-   ##
===========================================
+ Coverage    92.77%   93.63%   +0.85%     
===========================================
  Files           58       58              
  Lines         3143     2952     -191     
===========================================
- Hits          2916     2764     -152     
+ Misses         227      188      -39     
Impacted Files Coverage Δ
es/channel/internal.js 95.52% <100.00%> (ø)
es/utils/json-big.js 100.00% <100.00%> (+18.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51c661d...55645a9. Read the comment docs.

@davidyuk davidyuk force-pushed the feature/use-external-json-bigint branch 7 times, most recently from 69c9ea0 to 2aa60d0 Compare June 21, 2020 09:14
@davidyuk davidyuk force-pushed the feature/use-external-json-bigint branch from 2aa60d0 to 55645a9 Compare June 21, 2020 10:27
@davidyuk davidyuk marked this pull request as ready for review June 21, 2020 10:53
@davidyuk davidyuk requested a review from nduchak June 21, 2020 10:53
@mradkov mradkov added this to the 7.4.3 milestone Jul 1, 2020
@mradkov mradkov merged commit c7a2c13 into develop Jul 2, 2020
@davidyuk davidyuk deleted the feature/use-external-json-bigint branch July 2, 2020 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants