chore: Enable MIX_ENV=prod mix release to be run locally #1386
Conversation
seanhinde
changed the title
| def project() do | ||
| [ | ||
| app: :ae_mdw, | ||
| version: "1.48.1", | ||
| version: @version, |
There was a problem hiding this comment.
This is automatically handled by release please task on the pipeline.
There was a problem hiding this comment.
I switched to @Version because it's now used twice in the file. Will the release please task find and replace multiple instances? Will it replace the new one?
There was a problem hiding this comment.
I would rather just leave it for the CI to manage it as it has been doing or it would need to be validated in advance.
There was a problem hiding this comment.
Will the CI replace both places "1.48.1" will be hard coded if I remove this change to use a module attribute? The two places are here, and on line 123 of this file?
I can hard code 1.48.1 in both places, but it seems like a much worse solution, would quite likely break the CI anyway.
There was a problem hiding this comment.
I haven't tried it before but I think it's unlikely that it replaces in both places. One way to avoid the conflict is to pipe the list and append the releases.
The goal of this PR is to be able to create a fully transferable release containing all code from the node as well as the mdw code without relying on docker
To run, assuming a local checkout of the aeternity node in
../aeternity:NODEROOT=local INCLUDE_LOCAL_NODE=true MIX_ENV=prod mix releaseThis PR was sponsored by the ACF