Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert to lazy loaded aesara.link.c.cutils #1131

Merged

Conversation

brandonwillard
Copy link
Member

Fixes #1129

@brandonwillard brandonwillard self-assigned this Aug 20, 2022
@brandonwillard brandonwillard added bug Something isn't working important labels Aug 20, 2022
@brandonwillard brandonwillard force-pushed the fix-cutils-eager-importing branch 2 times, most recently from af22849 to 24dcbc6 Compare August 20, 2022 21:10
@codecov
Copy link

codecov bot commented Aug 20, 2022

Codecov Report

Merging #1131 (6542063) into main (83547c1) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1131      +/-   ##
==========================================
+ Coverage   79.23%   79.27%   +0.03%     
==========================================
  Files         159      159              
  Lines       48107    48108       +1     
  Branches    10935    10935              
==========================================
+ Hits        38118    38138      +20     
+ Misses       7475     7456      -19     
  Partials     2514     2514              
Impacted Files Coverage Δ
aesara/link/c/basic.py 87.59% <100.00%> (+0.01%) ⬆️
aesara/link/c/cmodule.py 54.37% <0.00%> (+0.08%) ⬆️
aesara/link/c/cutils.py 68.88% <0.00%> (+40.00%) ⬆️

@brandonwillard brandonwillard merged commit 813d040 into aesara-devs:main Aug 20, 2022
@brandonwillard brandonwillard deleted the fix-cutils-eager-importing branch August 20, 2022 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working important
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rel-2.7.10 breaks aesara-base conda-forge package
1 participant