Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Timeout in favor of thread.join(timeout) #104

Merged
merged 1 commit into from
Feb 9, 2021
Merged

Remove Timeout in favor of thread.join(timeout) #104

merged 1 commit into from
Feb 9, 2021

Conversation

MarcPer
Copy link
Contributor

@MarcPer MarcPer commented Jan 28, 2021

Deals with issue #103 .

@codecov-io
Copy link

codecov-io commented Jan 29, 2021

Codecov Report

Merging #104 (cf11895) into master (9998a89) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #104   +/-   ##
=======================================
  Coverage   92.60%   92.61%           
=======================================
  Files         175      175           
  Lines        9269     9270    +1     
=======================================
+ Hits         8584     8585    +1     
  Misses        685      685           
Impacted Files Coverage Δ
lib/aerospike/cluster.rb 90.69% <100.00%> (+0.32%) ⬆️
lib/aerospike/node/refresh/peers.rb 54.28% <0.00%> (-2.86%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9998a89...cf11895. Read the comment docs.

@nijikon
Copy link

nijikon commented Feb 8, 2021

@khaf can we merge and release this change?

@khaf
Copy link
Collaborator

khaf commented Feb 8, 2021

Absolutely. Sorry for the delay, I had to tend to a Go client issue. I'll release this change tomorrow.

@khaf khaf merged commit cf11895 into aerospike:master Feb 9, 2021
@MarcPer MarcPer deleted the no_timeout_module branch February 10, 2021 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants