Improvements on multi-record reports #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a process_separately parameter to define whether we want to handle multi-records by processing templates separately and merge them with PDFtk or to process it once by passing a single "objects" list, like it was possible in the original report_aeroo. Changed ValidationError to UserError which is more appropriate. Added need for PDFtk in README.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a
process_separatelyparameter to define whether we want tohandle multi-records by processing templates separately and merge them
with PDFtk or to process it once by passing a single "objects" list,
like it was possible in the original report_aeroo.
Changed ValidationError to UserError which is more appropriate.
Added need for PDFtk in README.