Fixed translations when not using lang templates #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Call to translate failed because of missing 'cr' as first arg. However, the original implementation lead to possible translation leaks between reports. Indeed, the call to translate does not refer to any res_id, so translate returned the first report string with the given source, ignoring the report's ID. This lead to issues since the same English wording can be translated differently depending on the context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Call to translate failed because of missing 'cr' as first arg.
However, the original implementation lead to possible translation
leaks between reports. Indeed, the call to translate does not refer to
any res_id, so translate returned the first report string with the
given source, ignoring the report's ID. This lead to issues since the
same English wording can be translated differently depending on the
context.