fix: watch loop issues #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pb82
approved these changes
Jun 25, 2018
aliok
reviewed
Jun 26, 2018
pkg/configOperator/configOperator.go
Outdated
| @@ -39,7 +40,9 @@ func (op ConfigOperator) StartService() { | |||
| log.Print("Entering watch loop") | |||
|
|
|||
| go op.startPollingUPS() | |||
| op.startKubeWatchLoop() | |||
| for { | |||
| op.startKubeWatchLoop() | |||
There was a problem hiding this comment.
@darahayes could you please document that this method is blocking and we have it in a for loop because watch might expire/timeout?
There was a problem hiding this comment.
@aliok sounds like a good idea!
|
@aliok I made some minor comments around the code. I figured it would be inappropriate to put this in the readme. Let me know what you think. |
|
@darahayes +1 on those comments. looks good. feel free to merge as Peter has approved it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems my editor also did some auto formatting but I guess that shouldn't really be an issue.