AER-3268 development pressure sources #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed some unused properties, and changed project category to be code-based (which is actually for future changes where it's actually a code, but might as well get it in there now).
These fields are not used in the ADMS model, and do not have any effect on input there, so not much point in having it prefixed with adms_. Could use nca_, but as they're generic codes anyway, we might as well use generic names in the metadata. Yes, this does 'break' old imports, but now seems a good moment to do this as we're moving to a new beta release.
These also survive a roundtrip in GML, as the new round trip case confirms (at least it works on my machine).
MichielJanssen-DAT
approved these changes
Oct 31, 2024
...imaer-shared/src/main/java/nl/overheid/aerius/shared/domain/calculation/ProjectCategory.java
Show resolved
Hide resolved
...shared/src/main/java/nl/overheid/aerius/shared/domain/calculation/NCACalculationOptions.java
Show resolved
Hide resolved
Hilbrand
approved these changes
Oct 31, 2024
...shared/src/main/java/nl/overheid/aerius/shared/domain/calculation/NCACalculationOptions.java
Show resolved
Hide resolved
...shared/src/main/java/nl/overheid/aerius/shared/domain/calculation/NCACalculationOptions.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also a small cleanup/deprecation in preparation of future work.