Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AER-3099 Added support for having multi adms met site properties for multiple years. #303

Merged
merged 3 commits into from
Oct 1, 2024

Conversation

Hilbrand
Copy link
Member

@Hilbrand Hilbrand commented Sep 27, 2024

This code introduces a new MetSurfaceCharacteristics object that replaces the single values in ADMSOptions. For backward compatibility the individual methods are kept in ADMSOptions, and will be removed when not used any more by upstream project. When multiple years are present in the met site data it's expected to have multiple met values for these years. In the calculation options these will be saved with the year as prefix to the option. If only 1 (or no) year is present no prefix will be used.

…ple years.

This code introduces a new MetSurfaceCharacteristics object that replaces the single values in ADMSOptions.
For backward compatibility the individual methods are kept in ADMSOptions, and will be removed when not used any more by upstream project.
Copy link
Member

@BertScholten BertScholten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Do wonder if we want to have met site characteristics be exported (not something user should have input on, and we shouldn't use the imported value?), but guess there was a reason for it at some point...

@Hilbrand Hilbrand force-pushed the AER-3099-mulitple-metdata branch 3 times, most recently from 3cc4e77 to fb12a26 Compare October 1, 2024 12:56
@Hilbrand Hilbrand force-pushed the AER-3099-mulitple-metdata branch from fb12a26 to ca4441f Compare October 1, 2024 12:57
@Hilbrand Hilbrand merged commit ab072e9 into aerius:main Oct 1, 2024
1 check passed
@Hilbrand Hilbrand deleted the AER-3099-mulitple-metdata branch October 1, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants