AER-2828 farm animal housing in IMAER #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed lodging from IMAER 6 (or replaced parts of it), as it should now be a good time to do so.
More in line with how we do this for other classes. Also added some more test cases for round trip.
Hilbrand
reviewed
May 6, 2024
source/imaer-gml/src/main/java/nl/overheid/aerius/gml/v6_0/togml/Source2GML.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced FarmLodging with the FarmAnimalHousing approach in IMAER 6.0. Lodging in old versions is still supported, and 5.1 will still export it as such (for now at least).
Does not include backwards compatibility, that'll be another PR.
Might break some (integration) tests in upstream projects.