Skip to content

Commit

Permalink
Adjusted github action workflow definitions to new version(#278)
Browse files Browse the repository at this point in the history
Defaults work better now (JDK default 17, ignore test defaults also make more sense)
As a result, PRs that have failing unittests should have a failing job, instead of seeming OK.
  • Loading branch information
BertScholten authored Jun 7, 2024
1 parent 15db5e2 commit 128296d
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,9 @@ jobs:
with:
repository: aerius/github-actions
path: aerius-github-actions
ref: v1.0.2
ref: v1.1

- uses: aerius/github-actions/events/pull_request-event-action@v1.0.2
- uses: aerius/github-actions/events/pull_request-event-action@v1.1
with:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
ROOT_POM_DIRECTORY: repo/source
JDK_VERSION: 17
5 changes: 2 additions & 3 deletions .github/workflows/on-push.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,12 @@ jobs:
with:
repository: aerius/github-actions
path: aerius-github-actions
ref: v1.0.2
ref: v1.1

- uses: aerius/github-actions/events/push-event-action@v1.0.2
- uses: aerius/github-actions/events/push-event-action@v1.1
with:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
NEXUS_USERNAME: ${{ secrets.NEXUS_USERNAME }}
NEXUS_PASSWORD: ${{ secrets.NEXUS_PASSWORD }}
ROOT_POM_DIRECTORY: repo/source
JDK_VERSION: 17
5 changes: 2 additions & 3 deletions .github/workflows/on-release-published.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,12 @@ jobs:
with:
repository: aerius/github-actions
path: aerius-github-actions
ref: v1.0.2
ref: v1.1

- uses: aerius/github-actions/events/release-event-action@v1.0.2
- uses: aerius/github-actions/events/release-event-action@v1.1
with:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
NEXUS_USERNAME: ${{ secrets.NEXUS_USERNAME }}
NEXUS_PASSWORD: ${{ secrets.NEXUS_PASSWORD }}
ROOT_POM_DIRECTORY: repo/source
JDK_VERSION: 17

0 comments on commit 128296d

Please sign in to comment.