AER-3178 Fix cold start SubSourceEmissionsCalculator (#297)

The cold start emissions calculator should return the emissions in kg/Year (it was g/year).

source/imaer-shared/src/main/java/nl/overheid/aerius/shared/emissions/SubSourceEmissionsCalculator.java

@@ -88,26 +88,28 @@ public Map<Substance, Double> calculateMaritimeRouteEmissions(final MaritimeShip
   }
 
   /**
-   * Calculates the emission of a {@link Vehicles} object.
+   * Calculates the emission of a {@link Vehicles} object and returns the values in Kg/Year.
    *
    * @param vehicle vehicle to calculate the emission on
-   * @return emissions calculated emissions
+   * @return emissions calculated emissions in Kg/Year.
    */
   public Map<Substance, Double> calculateColdStartEmissions(final Vehicles vehicle) throws AeriusException {
     // null is passed as road emission source since it has no additional information with coldstart for emission calculations.
     return coldStartEmissionsCalculator.calculateEmissions(null, vehicle)
-        .entrySet().stream().collect(Collectors.toMap(Map.Entry::getKey, entry -> entry.getValue().doubleValue()));
+        .entrySet().stream().collect(Collectors.toMap(Map.Entry::getKey, entry ->
+            coldStartEmissionsCalculator.toTotalEmission(null, entry.getValue(), null).doubleValue()));
   }
 
   /**
-   * Calculates the emission of a vehicle type on {@link StandardColdStartVehicles} object.
+   * Calculates the emission of a vehicle type on {@link StandardColdStartVehicles} object and returns the values in Kg/Year.
    *
    * @param vehicles object to get the time unit from
    * @param vehicleType vehicle type of the standard vehicle
-   * @return emissions calculated emissions
+   * @return emissions calculated emissions in Kg/Year.
    */
   public Map<Substance, Double> calculateColdStartEmissions(final StandardColdStartVehicles vehicles, final String vehicleType) {
     return coldStartEmissionsCalculator.calculateColdStartEmissions(vehicles, vehicleType, vehicles.getValuesPerVehicleTypes().get(vehicleType))
-        .entrySet().stream().collect(Collectors.toMap(Map.Entry::getKey, entry -> entry.getValue().doubleValue()));
+        .entrySet().stream().collect(Collectors.toMap(Map.Entry::getKey, entry ->
+            coldStartEmissionsCalculator.toTotalEmission(null, entry.getValue(), null).doubleValue()));
   }
 }

source/imaer-shared/src/test/java/nl/overheid/aerius/shared/emissions/ColdStartEmissionsCalculatorTest.java

@@ -51,7 +51,7 @@ class ColdStartEmissionsCalculatorTest {
   ColdStartEmissionsCalculator emissionsCalculator;
 
   @BeforeEach
-  void beforeEach() throws AeriusException {
+  void beforeEach() {
     emissionsCalculator = new ColdStartEmissionsCalculator(emissionFactorSupplier);
   }
 

source/imaer-shared/src/test/java/nl/overheid/aerius/shared/emissions/SubSourceEmissionsCalculatorTest.java

@@ -0,0 +1,79 @@
+/*
+ * Copyright the State of the Netherlands
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program.  If not, see http://www.gnu.org/licenses/.
+ */
+package nl.overheid.aerius.shared.emissions;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.mockito.ArgumentMatchers.eq;
+import static org.mockito.Mockito.doReturn;
+
+import java.math.BigDecimal;
+import java.util.Map;
+
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.ExtendWith;
+import org.mockito.Mock;
+import org.mockito.junit.jupiter.MockitoExtension;
+
+import nl.overheid.aerius.shared.domain.Substance;
+import nl.overheid.aerius.shared.domain.v2.base.TimeUnit;
+import nl.overheid.aerius.shared.domain.v2.source.road.CustomVehicles;
+import nl.overheid.aerius.shared.domain.v2.source.road.StandardColdStartVehicles;
+import nl.overheid.aerius.shared.exception.AeriusException;
+
+/**
+ * Test class for {@link SubSourceEmissionsCalculator}.
+ */
+@ExtendWith(MockitoExtension.class)
+class SubSourceEmissionsCalculatorTest {
+
+  private @Mock ColdStartEmissionFactorSupplier emissionFactorSupplier;
+
+  private SubSourceEmissionsCalculator subSourceEmissionsCalculator;
+
+  @BeforeEach
+  void beforeEach() {
+    final ColdStartEmissionsCalculator emissionsCalculator = new ColdStartEmissionsCalculator(emissionFactorSupplier);
+    subSourceEmissionsCalculator = new SubSourceEmissionsCalculator(null, null, null, emissionsCalculator);
+  }
+
+  @Test
+  void testCalculateColdStartEmissionsPerVehicle() throws AeriusException {
+    final CustomVehicles vehicle = new CustomVehicles();
+    vehicle.setTimeUnit(TimeUnit.DAY);
+    vehicle.setVehiclesPerTimeUnit(2002);
+    vehicle.getEmissionFactors().put(Substance.NOX, 0.02);
+    final Map<Substance, Double> emissions = subSourceEmissionsCalculator.calculateColdStartEmissions(vehicle);
+
+    assertEquals(emissionInKgPerYear(2002, 0.02), emissions.get(Substance.NOX), "Should return correct emission per Kg per Year");
+  }
+
+  @Test
+  void testCalculateColdStartEmissionsStandardColdStartVehicles() {
+    final StandardColdStartVehicles vehicle = new StandardColdStartVehicles();
+    vehicle.setTimeUnit(TimeUnit.DAY);
+    vehicle.setValuesPerVehicleTypes(Map.of("BUS", 2002.0));
+    doReturn(Map.of(Substance.NOX, 0.02)).when(emissionFactorSupplier).getColdStartStandardVehicleEmissionFactors(eq("BUS"));
+    final Map<Substance, Double> emissions = subSourceEmissionsCalculator.calculateColdStartEmissions(vehicle, "BUS");
+
+    assertEquals(emissionInKgPerYear(2002, 0.02), emissions.get(Substance.NOX), "Should return correct emission per Kg per Year");
+  }
+
+  private static double emissionInKgPerYear(final int numberOfVehicles, final double emissionGramPerColdstart) {
+    return BigDecimal.valueOf(numberOfVehicles * 365 * emissionGramPerColdstart).divide(BigDecimal.valueOf(1000.0)).doubleValue();
+  }
+}