Upstream merge 3 #90
Upstream merge 3 #90
Conversation
This would cause crashes when trying to tag an account that was just created
use snprintf "just in case" where appropriate consistently use unsigned for temp values pass std::string by const ref rather than by value add length check (which can't happen in practice) for memcpy
Annoyingly, its locking semantics are borked since it does not do any locking
on_generateblocks RPC call combines functionality from the on_getblocktemplate and on_submitblock RPC calls to allow rapid block creation. Difficulty is set permanently to 1 for regtest. Makes use of FAKECHAIN network type, but takes hard fork heights from mainchain Default reserve_size in generate_blocks RPC call is now 1. If it is 0, the following error occurs 'Failed to calculate offset for'. Queries hard fork heights info of other network types
…ero#3981 This gets rid of the temporary precalc cache. Also make the RPC able to send data back in binary or JSON, since there can be a lot of data This bumps the LMDB database format to v3, with migration.
This should help new nodes predict how much disk space will be needed for a full sync
This is called a lot when creating a block template, and does not change until the blockchain changes. This also avoids tx parsing when cached.
…o#4061 Helps a bit when running with valgrind
For some reason, this confuses and kills ASAN on startup as it thinks const uint8_t ipv4_network_address::ID is defined multiple times.
…s /monero#4076 when a block being added to the main chain is invalid. This ensures the peer is banned after a number of these.
This can happen when there's a very large reorg on the daemon (ie, on testnet)
Takes advantage of caching
Subaddresses are better for privacy
Some of them don't like it
This would only throw
|
is this ready to merge? |
|
Built on Ubuntu 16.04 and Windows 10 - no issues. |
|
I've built on docker for ubuntu 18.10 and it builds fully (can't test but it builds everything). Built on high sierra 10.13.6 no issues that I can see on send/receive/restore wallet. Also built on windows 10 msys-64 (no testing of wallet just daemon). |
|
Built on the following OSes without issues and did a quick test of running the daemon and creating a wallet: Unfortunately can't do more tests at the moment. EDIT: wallet-rpc also working fine. |
This PR merges upstream patches after monero-project#4067 which is the last one included in #77; specifically, it includes upstream PRs from monero-project#4004 merged on July 3 up to monero-project#4129 merged on July 28: