Various wallet improvements (nuke TransferOriginal, unlock_time, etc) #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stoffu
changed the title
|
OS: Ubuntu 16.04.6 LTS Unable to build past 77%; see below. |
…#4728 it doesn't display the details, which are already displayed in show_transfer
…when querying seed /monero#4801 Followup on monero-project#4653
…ocked for show_transfers /monero#4817 Followup on monero-project#4728
…monero#5382 It was not filled out for in and pool types
It makes more sense than (uint64_t)-1, which is going to look like very much confirmed when not checking in_pool
also add a note when receiving the tx, because the user might not notice the "XXX blocks to unlock" in the balance.
|
@420coupe |
|
OS: Ubuntu 18.04.2 OS: Ubuntu 18.10 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
monero-project#4253
monero-project#4388
monero-project#4653
monero-project#4278
monero-project#4801
monero-project#4817
monero-project#4236
monero-project#5282
monero-project#5382
monero-project#5548