Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add emphasis to start-repl line #54

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add emphasis to start-repl line #54

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Apr 20, 2017

It's actually really easy to miss the start-repl line, and once you get connected, the REPL looks like it's been brought up successfully.

It's actually really easy to miss the `start-repl` line, and once you get connected, the REPL looks like it's been brought up successfully.
@martinklepsch
Copy link
Contributor

I'd rather (or in addition possibly) see the start-repl note in the Usage section emphasized. I guess many people will just read this section and miss the (start-repl) call...

Have you read the documentation where you made changes before and it wasn't clear that running (start-repl) is required?

@ghost
Copy link
Author

ghost commented Apr 20, 2017

That was actually how I ran into this problem. Somehow it is possible to miss it.

I considered adding a short paragraph explaining how the client needs to start a server on its side and connect to the websocket URL provided by the nREPL server, but I thought it might have been too long. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants