Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Drop-in v6 #106

Merged
merged 6 commits into from
Dec 23, 2024
Merged

Support Drop-in v6 #106

merged 6 commits into from
Dec 23, 2024

Conversation

gcatanese
Copy link
Contributor

Support Drop-in v6:

  • move tests for Drop-in v5 in folder /5
  • create new tests for Drop-in v6 in folder /6

E2E GitHub configuration of existing applications will be changed to use v5 tests, until we progressively migrate them to use Drop-in v6.

Kwok-he-Chu
Kwok-he-Chu reviewed Dec 2, 2024
View reviewed changes
Copy link
Contributor

@Kwok-he-Chu Kwok-he-Chu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, kept it backwards compatible.

Would it be an idea to name the tests to their respective version, f.e. iDeal v6?

One more nit: Let's update the README to explain V5 and V6 - Link Adyen.Web release notes or docs

Dockerfile Show resolved Hide resolved
@gcatanese gcatanese merged commit 91cd566 into main Dec 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kwok-he-Chu Kwok-he-Chu Kwok-he-Chu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gcatanese @Kwok-he-Chu