Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NovaEditorJsData constructor issues #68

Merged
merged 3 commits into from
Jul 17, 2022
Merged

Fix NovaEditorJsData constructor issues #68

merged 3 commits into from
Jul 17, 2022

Conversation

roelofr
Copy link
Collaborator

@roelofr roelofr commented Jul 16, 2022

In certain scenarios, the NovaEditorJsData data model would recieve a null value as constructor argument.
This would crash the foreach loop.

Now, the NovaEditorJsData accepts all data types, decoding strings as JSON (as it did before), and wrapping non-iterables in an array.

Closes #65

@roelofr roelofr requested review from stickeerehan and advoor July 16, 2022 14:48
@roelofr roelofr added the bug Something isn't working label Jul 17, 2022
@roelofr roelofr merged commit 8be8b21 into master Jul 17, 2022
@roelofr roelofr deleted the fix-data-object branch September 28, 2022 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stickeerehan stickeerehan Awaiting requested review from stickeerehan

@advoor advoor Awaiting requested review from advoor

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

foreach() argument error
1 participant
@roelofr