Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distinguish between multiple dependency snapshots of the same type #88

Merged
merged 5 commits into from
Aug 7, 2024

Conversation

david-wiggs
Copy link
Contributor

This is a re-cut of #80 (as it got a bit stale) after some testing and comments from @ebickle. In general, it addresses #73 and should hopefully help those that use a matrix approach.

Copy link
Contributor

@mrysav mrysav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks OK 👍 But I'd like to give someone else who has a longer history with the Action a chance to review. cc @peter-murray or @hmaurer?

@hmaurer
Copy link
Contributor

hmaurer commented Aug 5, 2024

@david-wiggs 👋 my apologies for the delay in reviewing this. I am wondering if we could instead omit the correlator input and automatically specify it based on directory. It would be a breaking change for existing users so we'd need to release this under a new major version, though 🤔

All in all I think this change is okay and it'll be useful for folks to be able to override the correlator as an escape-hatch; I'm 👍 for release this.

@david-wiggs
Copy link
Contributor Author

Hey there @hmaurer thank you for your review and comments

I am wondering if we could instead omit the correlator input and automatically specify it based on directory.

Yes, I think this is a good approach for an additional change. Thank you for approving this one, as it unblocks a current use case. Is there an expectation on when this might get merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants