Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make action GHES compatible #40

Merged
merged 4 commits into from
May 31, 2023
Merged

Make action GHES compatible #40

merged 4 commits into from
May 31, 2023

Conversation

cnagadya
Copy link
Contributor

@cnagadya cnagadya commented May 31, 2023

As stated in https://github.com/github/dependency-graph/issues/2130, earlier versions of the dependency @github/dependency-submission-toolkit arent GHES compatible. This PR updates the dependency to the latest version to fix this and also bumps up the version to 3.0.2

@cnagadya cnagadya changed the title Update @github/dependency-submission-toolkit Make action GHES compatible May 31, 2023
@cnagadya cnagadya marked this pull request as ready for review May 31, 2023 09:16
@@ -510,7 +510,7 @@ function getDetector() {
function generateDependencyGraph(directory, config) {
return __awaiter(this, void 0, void 0, function* () {
try {
const mvn = new maven_runner_1.MavenRunner(directory, config === null || config === void 0 ? void 0 : config.settingsFile, config === null || config === void 0 ? void 0 : config.ignoreMavenWrapper);
const mvn = new maven_runner_1.MavenRunner(directory, config === null || config === void 0 ? void 0 : config.settingsFile, config === null || config === void 0 ? void 0 : config.ignoreMavenWrapper, config === null || config === void 0 ? void 0 : config.mavenArgs);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be from one of the v3.0.1 commits. Probably npm build wasnt run then 🤔

@lseppala lseppala merged commit c5ad0fd into advanced-security:main May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants