-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
626 save advanced searches #629
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking that the saved searches will be outside so they can apply different searches fast. Probably too late to make the change?
apps/web/messages/en.json
Outdated
"groupUser": "User", | ||
"groupOrganization": "Organization", | ||
"save": "Save", | ||
"saveTooltip": "Save / Save as", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"saveTooltip": "Save / Save as", | |
"saveTooltip": "Rename / Save / Save as", |
You can update the name as well
if (values.saveType === SaveTypes.Update) isOrganization = props.isSelectedSearchOrganization; | ||
const idToUpdate = values.saveType === SaveTypes.Update ? props.selectedSearchID : null; | ||
props.handleSave(name, isOrganization, idToUpdate); | ||
form.reset(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when the type is Update, we may want to order the searches again, since this is the current behavior. For example if I rename aaa to zzz, I would expect the updated entry to be on the bottom (which it does if you refresh)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apps/web/src/components/search/saved-searches/saved-searches.tsx
Outdated
Show resolved
Hide resolved
value={selectedSearchID} | ||
onChange={handleChange} | ||
/> | ||
<Save |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should save be enabled if there is no query?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, fixed!
}); | ||
return; | ||
} | ||
const responseID = res.data.upsertSearchQueryString.id; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Id instead of ID maybe? :)
apps/web/src/components/search/saved-searches/saved-searches.tsx
Outdated
Show resolved
Hide resolved
apps/web/src/components/search/saved-searches/saved-searches.tsx
Outdated
Show resolved
Hide resolved
apps/web/src/components/search/saved-searches/saved-searches.tsx
Outdated
Show resolved
Hide resolved
818492d
to
aa2becb
Compare
Co-authored-by: Giorgos Trichopoulos <[email protected]>
Co-authored-by: Giorgos Trichopoulos <[email protected]>
Co-authored-by: Giorgos Trichopoulos <[email protected]>
Co-authored-by: Giorgos Trichopoulos <[email protected]>
Can do it in a different task if @dennis-adsviewer thinks that's better. |
Saved searches added to the advanced searches modal.
Members can crud searches for themselves and can read organizational searches.
Operators and org admins are the only ones who may create/update/delete organizational searches.
closes #565