626 save advanced searches #629
Conversation
apps/web/messages/en.json
Outdated
| "groupUser": "User", | ||
| "groupOrganization": "Organization", | ||
| "save": "Save", | ||
| "saveTooltip": "Save / Save as", |
There was a problem hiding this comment.
| "saveTooltip": "Save / Save as", | |
| "saveTooltip": "Rename / Save / Save as", |
You can update the name as well
| if (values.saveType === SaveTypes.Update) isOrganization = props.isSelectedSearchOrganization; | ||
| const idToUpdate = values.saveType === SaveTypes.Update ? props.selectedSearchID : null; | ||
| props.handleSave(name, isOrganization, idToUpdate); | ||
| form.reset(); |
There was a problem hiding this comment.
when the type is Update, we may want to order the searches again, since this is the current behavior. For example if I rename aaa to zzz, I would expect the updated entry to be on the bottom (which it does if you refresh)
There was a problem hiding this comment.
Doesn't seem to behave that way (this is the fetched data withou updating).
apps/web/src/components/search/saved-searches/saved-searches.tsx
Outdated
Show resolved
Hide resolved
| value={selectedSearchID} | ||
| onChange={handleChange} | ||
| /> | ||
| <Save |
There was a problem hiding this comment.
should save be enabled if there is no query?
| }); | ||
| return; | ||
| } | ||
| const responseID = res.data.upsertSearchQueryString.id; |
There was a problem hiding this comment.
Id instead of ID maybe? :)
apps/web/src/components/search/saved-searches/saved-searches.tsx
Outdated
Show resolved
Hide resolved
apps/web/src/components/search/saved-searches/saved-searches.tsx
Outdated
Show resolved
Hide resolved
apps/web/src/components/search/saved-searches/saved-searches.tsx
Outdated
Show resolved
Hide resolved
elevchyt
force-pushed
the
626-save-advanced-searches
branch
from
818492d
to
aa2becb
Compare
Co-authored-by: Giorgos Trichopoulos <[email protected]>
Co-authored-by: Giorgos Trichopoulos <[email protected]>
Co-authored-by: Giorgos Trichopoulos <[email protected]>
Co-authored-by: Giorgos Trichopoulos <[email protected]>
Can do it in a different task if @dennis-adsviewer thinks that's better. |
Saved searches added to the advanced searches modal.
Members can crud searches for themselves and can read organizational searches.
Operators and org admins are the only ones who may create/update/delete organizational searches.
closes #565