Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add facet search 2nd level #338

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

thostetler
Copy link
Member

@thostetler thostetler commented Oct 27, 2023

  • Support searching on 2nd level facet modal
    Adds the search bar onto the second level of the facet modal
    image

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #338 (9be635d) into master (3cc36d7) will increase coverage by 0.00%.
The diff coverage is 15.90%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #338   +/-   ##
=======================================
  Coverage   48.13%   48.14%           
=======================================
  Files         369      369           
  Lines       37033    37034    +1     
  Branches      511      511           
=======================================
+ Hits        17827    17829    +2     
+ Misses      19197    19196    -1     
  Partials        9        9           
Files Coverage Δ
...nents/SearchFacet/SearchFacetModal/SearchInput.tsx 100.00% <100.00%> (ø)
src/components/SearchFacet/store/FacetStore.ts 87.12% <100.00%> (ø)
src/components/SearchFacet/useGetFacetData.ts 22.51% <20.00%> (+0.05%) ⬆️
src/components/SearchFacet/FacetList.tsx 20.87% <10.00%> (+0.27%) ⬆️
.../SearchFacet/SearchFacetModal/SearchFacetModal.tsx 26.17% <0.00%> (+0.34%) ⬆️

@thostetler thostetler force-pushed the add-facet-search-2nd-level branch from c757e20 to 0703b5d Compare October 30, 2023 21:11
@thostetler thostetler force-pushed the add-facet-search-2nd-level branch from 0703b5d to 9be635d Compare October 30, 2023 21:11
@thostetler thostetler requested a review from shinyichen October 30, 2023 21:24
@thostetler thostetler merged commit 590c81c into adsabs:master Oct 31, 2023
4 checks passed
@thostetler thostetler deleted the add-facet-search-2nd-level branch October 31, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants