-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
General fixes 1 #337
Merged
Merged
General fixes 1 #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
thostetler
commented
Oct 27, 2023
- Add a HideOnPrint utility component
- Fix bug with create-component script
- Switch over any lingering Tailwindcss class usages
- Remove tailwindcss, postcss, and autoprefixer
- Update all global tailwind classes to css equivalents
- Remove TypeaheadMenu.tsx, not used
- Fix focus ring around compound-components
- Add status:rejected to works table filter
- Improve visibility of clear button on facet selection list
- get husky lint-staged working again
- Remove momentjs, slight fix to parsePubDate utility
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #337 +/- ##
==========================================
- Coverage 48.17% 48.13% -0.04%
==========================================
Files 367 369 +2
Lines 36950 37033 +83
Branches 511 511
==========================================
+ Hits 17799 17827 +28
- Misses 19142 19197 +55
Partials 9 9
|
Components that are composed of multiple controls, we should surround the entire control with a focus ring when the primary control is focused.
thostetler
force-pushed
the
general-fixes-1
branch
from
October 28, 2023 03:52
4b5ba35
to
cf43a6f
Compare
shinyichen
requested changes
Oct 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No other comments besides the highlights
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.