Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General fixes 1 #337

Merged
merged 14 commits into from
Oct 30, 2023
Merged

General fixes 1 #337

merged 14 commits into from
Oct 30, 2023

Conversation

thostetler
Copy link
Member

  • Add a HideOnPrint utility component
  • Fix bug with create-component script
  • Switch over any lingering Tailwindcss class usages
  • Remove tailwindcss, postcss, and autoprefixer
  • Update all global tailwind classes to css equivalents
  • Remove TypeaheadMenu.tsx, not used
  • Fix focus ring around compound-components
  • Add status:rejected to works table filter
  • Improve visibility of clear button on facet selection list
  • get husky lint-staged working again
  • Remove momentjs, slight fix to parsePubDate utility

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #337 (93bf653) into master (ae7b967) will decrease coverage by 0.04%.
The diff coverage is 31.29%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #337      +/-   ##
==========================================
- Coverage   48.17%   48.13%   -0.04%     
==========================================
  Files         367      369       +2     
  Lines       36950    37033      +83     
  Branches      511      511              
==========================================
+ Hits        17799    17827      +28     
- Misses      19142    19197      +55     
  Partials        9        9              
Files Coverage Δ
src/components/HideOnPrint/index.ts 100.00% <100.00%> (ø)
src/components/SearchBar/SearchInput.tsx 82.69% <100.00%> (+0.94%) ⬆️
src/components/Slider/Slider.tsx 64.43% <100.00%> (+0.35%) ⬆️
src/components/index.ts 100.00% <100.00%> (ø)
...s/FeedbackForms/MissingRecord/DiffSectionPanel.tsx 21.15% <0.00%> (ø)
...onents/FeedbackForms/MissingRecord/RecordPanel.tsx 13.74% <85.71%> (+0.34%) ⬆️
src/components/NavBar/NavBar.tsx 31.70% <50.00%> (ø)
src/components/Orcid/AddToOrcidButton.tsx 23.40% <50.00%> (ø)
src/components/Orcid/DeleteFromOrcidButton.tsx 24.00% <50.00%> (ø)
src/components/ResultList/ListActions.tsx 17.39% <50.00%> (+0.31%) ⬆️
... and 11 more

Copy link
Member

@shinyichen shinyichen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No other comments besides the highlights

src/components/ResultList/Item/Item.tsx Show resolved Hide resolved
@thostetler thostetler merged commit 3cc36d7 into adsabs:master Oct 30, 2023
3 of 4 checks passed
@thostetler thostetler deleted the general-fixes-1 branch October 30, 2023 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants