My Libraries

[shinyichen]

All the existing libraries implementations

• Settings: update metadata, change ownership, add collaborators, delete library
• Adding/Deleting papers to library from search results and abstract page
• Public library view
  https://github.com/adsabs/nectar/assets/636361/37487083-b9d8-4325-a1e1-1475132efc3b

[codecov]

Codecov Report

Merging #336 (9add16f) into master (590c81c) will decrease coverage by 0.33%.
Report is 2 commits behind head on master.
The diff coverage is 44.33%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #336      +/-   ##
==========================================
- Coverage   48.14%   47.81%   -0.33%     
==========================================
  Files         369      389      +20     
  Lines       37034    40442    +3408     
  Branches      511      554      +43     
==========================================
+ Hits        17829    19337    +1508     
- Misses      19196    21093    +1897     
- Partials        9       12       +3     

Files	Coverage Δ
src/api/biblib/index.ts	100.00% <100.00%> (ø)
src/api/biblib/types.ts	100.00% <100.00%> (ø)
src/api/models.ts	100.00% <100.00%> (ø)
src/api/search/types.ts	100.00% <100.00%> (ø)
src/components/Libraries/TableSkeleton.tsx	100.00% <100.00%> (ø)
src/components/Libraries/index.ts	100.00% <100.00%> (ø)
src/components/Libraries/types.ts	100.00% <100.00%> (ø)
src/components/Pagination/index.ts	100.00% <100.00%> (ø)
src/components/ResultList/useHighlights.ts	86.20% <100.00%> (ø)
src/components/SearchBar/SearchInput.tsx	82.57% <ø> (-0.13%)	⬇️
... and 24 more

... and 2 files with indirect coverage changes

[thostetler]

I think we should hide the pagination controls and operations when no libraries are found.

[thostetler]

should lowercase the 'a'

---

I think we could have a little more vertical margin, feels a little closed in when you have a low amount of libs

---

We could probably keep the modal open and let the user know that the name they chose was already taken. I'm thinking of a situation where I entered the wrong name, but wrote out a long description -- currently I'd lose what I wrote...

---

https://github.com/adsabs/nectar/assets/6970899/5b2d92e9-539e-4702-a4f2-614027cba5a3
The back button on a paper details page doesn't go back to main libraries page as I would expect

---

Seems like collaborators are slightly off center

---

I think I would prefer the modal to be bigger so the library list isn't quite so tight

---

https://github.com/adsabs/nectar/assets/6970899/17aaa5c3-a587-486c-9089-aa62d139cafc
Seeing a bug where after adding a new library it's not showing up in the list

---

Should use humanized date strings, similar to how we have it in the ORCiD works table:

nectar/src/components/Orcid/WorksTable.tsx

Line 304 in 2281f59

const getUpdated = (date: string) => {

---

On library details page, when request is blocked (error state) the page remains in a loading state

---

on the main libraries table, if biblib requests are blocked, the page throws an error

---

I'm not clear on the purpose of the dropdown at the top.

---

https://github.com/adsabs/nectar/assets/6970899/130067b3-f4bb-4b62-8829-46c2e637265c
Deleting a library from settings does not update the main library list.

---

Other small nits:

• In the modals that are in use, we should place focus into whatever primary input/button

[thostetler]

Nice work, everything works well and feels natural coming from BBB. I have a few things I noticed, but no show stoppers.
LGTM

[thostetler]

We should have a component for these back links. This should work like a stack that we 'push' as we dig in, and 'pop' as we go back up

[shinyichen]

What's the advantage for the component? I can add a task for this.

[thostetler]

Yeah we could think about it anyway, we should probably use hash urls or something like that as well for the sub-views so that we could keep track of it/shareable/etc.

[shinyichen]

I think we should hide the pagination controls and operations when no libraries are found.

Resolved

[shinyichen]

Resolved.

The drop down is a placeholder where we will have 'my libraries', 'shared with me' and 'following' in the future.

should lowercase the 'a'

I think we could have a little more vertical margin, feels a little closed in when you have a low amount of libs

We could probably keep the modal open and let the user know that the name they chose was already taken. I'm thinking of a situation where I entered the wrong name, but wrote out a long description -- currently I'd lose what I wrote...

https://github.com/adsabs/nectar/assets/6970899/5b2d92e9-539e-4702-a4f2-614027cba5a3 The back button on a paper details page doesn't go back to main libraries page as I would expect

Seems like collaborators are slightly off center

I think I would prefer the modal to be bigger so the library list isn't quite so tight

https://github.com/adsabs/nectar/assets/6970899/17aaa5c3-a587-486c-9089-aa62d139cafc Seeing a bug where after adding a new library it's not showing up in the list

Should use humanized date strings, similar to how we have it in the ORCiD works table:

nectar/src/components/Orcid/WorksTable.tsx

Line 304 in 2281f59

const getUpdated = (date: string) => {

On library details page, when request is blocked (error state) the page remains in a loading state

on the main libraries table, if biblib requests are blocked, the page throws an error

I'm not clear on the purpose of the dropdown at the top.

https://github.com/adsabs/nectar/assets/6970899/130067b3-f4bb-4b62-8829-46c2e637265c Deleting a library from settings does not update the main library list.

Other small nits:

• In the modals that are in use, we should place focus into whatever primary input/button

should lowercase the 'a'

I think we could have a little more vertical margin, feels a little closed in when you have a low amount of libs

We could probably keep the modal open and let the user know that the name they chose was already taken. I'm thinking of a situation where I entered the wrong name, but wrote out a long description -- currently I'd lose what I wrote...

https://github.com/adsabs/nectar/assets/6970899/5b2d92e9-539e-4702-a4f2-614027cba5a3 The back button on a paper details page doesn't go back to main libraries page as I would expect

Seems like collaborators are slightly off center

I think I would prefer the modal to be bigger so the library list isn't quite so tight

https://github.com/adsabs/nectar/assets/6970899/17aaa5c3-a587-486c-9089-aa62d139cafc Seeing a bug where after adding a new library it's not showing up in the list

Should use humanized date strings, similar to how we have it in the ORCiD works table:

nectar/src/components/Orcid/WorksTable.tsx

Line 304 in 2281f59

const getUpdated = (date: string) => {

On library details page, when request is blocked (error state) the page remains in a loading state

on the main libraries table, if biblib requests are blocked, the page throws an error

I'm not clear on the purpose of the dropdown at the top.

https://github.com/adsabs/nectar/assets/6970899/130067b3-f4bb-4b62-8829-46c2e637265c Deleting a library from settings does not update the main library list.

Other small nits:

• In the modals that are in use, we should place focus into whatever primary input/button

[shinyichen]

@thostetler All the items are resolved. One item with the linking I think can be a separate task.