Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in document #36

Open
acscott opened this issue Jan 12, 2018 · 1 comment
Open

Typo in document #36

acscott opened this issue Jan 12, 2018 · 1 comment

Comments

@acscott
Copy link

acscott commented Jan 12, 2018

Hi,
for the example to get specific metrics (https://github.com/adsabs/adsabs-dev-api/blob/master/metrics.md) I tried using "types" delimited by single apostrophe but the server didn't like it:
curl -H "Authorization: Bearer " -H "Content-Type: application/json" -X POST -d '{"bibcodes":["1980ApJS...44..137K","1980ApJS...44..489B"],'types':['basic']}' https://api.adsabs.harvard.edu/v1/metrics

So I changed it to be consistent with the bibcodes and use double-quotes and it worked.

Hope this helps someone.

@taylorshaulis
Copy link

Thank you for reporting this @acscott

I can confirm this issue

The example documented breaks out of the data (-d) argument string which is enclosed in single quotes

taylorshaulis pushed a commit that referenced this issue Jan 12, 2018
This pr is to resolve issue #36

The provided curl example breaks out of the data argument string and needed to use double quotes inside the string instead of single quotes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants