Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alembic functions #53

Merged
merged 4 commits into from
May 3, 2022
Merged

Alembic functions #53

merged 4 commits into from
May 3, 2022

Conversation

tjacovich
Copy link
Contributor

Refactored populate_bibcode_column to:

  • Remove alembic wrapper functions.
  • Better handle being run on a db with curated_metadata.

Added alembic revision to:

  • Capitalize all alt bibcodes.
  • Remove the canonical bibcode from the alt bibcode list.

marblestation
marblestation approved these changes May 3, 2022
View reviewed changes
Copy link
Contributor

@marblestation marblestation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!

@marblestation marblestation merged commit 274b3fd into adsabs:master May 3, 2022
@tjacovich tjacovich deleted the alembic_functions branch May 3, 2022 14:38
tjacovich added a commit to tjacovich/ADSCitationCapture that referenced this pull request May 3, 2022
@tjacovich
Merged PR adsabs#53 into branch.
2dfec1a
tjacovich added a commit to tjacovich/ADSCitationCapture that referenced this pull request May 3, 2022
@tjacovich
Merged PR adsabs#53
9451ba3
tjacovich added a commit to tjacovich/ADSCitationCapture that referenced this pull request May 3, 2022
@tjacovich
Merged PR adsabs#53
de4e52b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marblestation marblestation marblestation approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tjacovich @marblestation