Fix confusing ReadError traceback

tests/test_syntax_errors.py

@@ -92,3 +92,28 @@ def test_sets(self):
                    '    a:\n'
                    '      set\n'
                    '...\n', None)
+
+    def test_invalid_char_last(self):
+        self.check('---\nkey: value\t\n',
+                   None, problem=(2, 11))
+
+    def test_invalid_char_first(self):
+        self.check('---\n\tkey: value\n',
+                   None, problem=(2, 1))
+
+    def test_invalid_char_on_second_line(self):
+        self.check('---\nfoo: bar\n\toutput: foo\n',
+                   None, problem=(3, 1))
+
+    def test_invalid_chars(self):
+        # We expect to identify only the first syntax error as this kind of
+        # error is fatal (stops parsing)
+        self.check('---\nkey: \tfoo\tbar\n',
+                   None,
+                   problem=(2, 6))
+
+    def test_invalid_char_with_other_rule(self):
+        self.check('key: value\t\n',
+                   None,
+                   problem1=(1, 1, 'document-start'),
+                   problem2=(1, 11))

yamllint/linter.py

@@ -186,6 +186,15 @@ def get_syntax_error(buffer):
                               'syntax error: ' + e.problem + ' (syntax)')
         problem.level = 'error'
         return problem
+    except yaml.reader.ReaderError as e:
+        # we need to convert position into line+column
+        line = buffer.count('\n', 0, e.position)
+        col = e.position - (buffer.rindex('\n', 0, e.position) if line else 1)
+        problem = LintProblem(line + 1,
+                              col,
+                              'syntax error: ' + e.reason + ' (syntax)')
+        problem.level = 'error'
+        return problem
 
 
 def _run(buffer, conf, filepath):

yamllint/parser.py

@@ -121,9 +121,9 @@ def comments_between_tokens(token1, token2):
 
 
 def token_or_comment_generator(buffer):
-    yaml_loader = yaml.BaseLoader(buffer)
 
     try:
+        yaml_loader = yaml.BaseLoader(buffer)
         prev = None
         curr = yaml_loader.get_token()
         while curr is not None:
@@ -139,7 +139,8 @@ def token_or_comment_generator(buffer):
             prev = curr
             curr = next
 
-    except yaml.scanner.ScannerError:
+    # errors like this are already analysed by get_syntax_error
+    except (yaml.scanner.ScannerError, yaml.reader.ReaderError):
         pass