This repository has been archived by the owner on Jan 27, 2022. It is now read-only.
Add support for hold invoices #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do I still need to use make with tags="invoicesrpc" flag to take advantage of hodl invoices in lnd v0.6? |
|
@dgnsrekt Yes you do. v0.6 is currently at rc4 so still requires building with the invoicesrpc subserver. |
This commit adds support for hold invoices which is a part of the invoicesrpc subserver
|
Force push was an amendment to the last commit to add the new whitespace characters that keep showing up every time I recompile the protocol buffers. This update will ensure the next compile doesn't mark the file as having an update when it doesn't include any new changes. |
|
Check out https://github.com/sako0938/lnd-grpc-client if you want, Im starting to add support for more subsystems, but Im just a beginner at async programming! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With lnd 0.6, support for hold invoices has been merged. Hold invoices allow merchants to delay the settlement of invoices until conditions for fulfilling the service has been met - say for instance an inventory check. see here.
This pull request merges support for creating, settling and cancelling hold invoices into the lnd-grpc-client library. There were a few backwards-compatible changes to the regular rpc protocol buffers: support for static channel backups, new address types, peer states and a new descriptor for utxos were added. For a full list of the changes, please consult the diff.