properly handle subscribed topics with + wildcard #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianromero
requested changes
Oct 8, 2019
|
I already replaced |
|
Merged! As you can see it is needed to merge your changes into the branch mobile to make the gradle script work for Android and Java 8. I have two different gradle build files. One for desktop and java 11 in the master branch and other for android and java 8 in the branch mobile. Maybe I should create one single gradle build file for both environments. Thanks |
|
Thank you so much for accepting the PR, and for creating such wonderful work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently subscribe panels can handle wildcard topics containing # properly, but not topics containing +. This pull request contains a fix that allows a subscribe panel with + as part of the topic name to correctly receive incoming messages by employing a topic matching function available in Paho's MQTT implementation.