Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

August 2023 updates #252

Merged
merged 19 commits into from
Aug 18, 2023
Merged

August 2023 updates #252

merged 19 commits into from
Aug 18, 2023

Conversation

adrianoc
Copy link
Owner

f5dfb34 fixes code not awaiting on async call
4ff966d bump version to 2.5.0
5aa22e6 fixes plain value type being assigned to nullable variables in some scenarios (#251)
b4dbf5f fixes methods taking nullable parameters could generate multiple MethodDefinitions (#245)
8399517 fix generated code for stobj opcode missing target type (#246)
a6b0541 fixes instantiation of value types in ternary operators (#248)
53deec7 implements unboxing (#249)
d03b853 fixes local variable initializer handling for value types on expressions other than ObjectCreationExpression
6d65c3c removes unused travis configuration file
10d2b4e refactoring improving code to add instruction after existing one to avoid having 2 steps: create / add instruction, which makes the code less readable
c4261c4 updates packages
b41d9af loads address of value type array element when accessing members of the element (#247)
e9dca1c fixes object initializer expression in array element assignment (#243)
e11307c fixes ldelema instruction missing target type and updates expecteation in tests accordingly
a74893e fixes object initializer expression handling when used in parameterless value type instantiation (#243)
6e32506 removes code duplication and moves method declaration for better organization (part of #243)
4d9819b improves generated code for equality/inequality of objects against null (#242)
71b9c5d updates test expectations to match new format
628214e improves switch code generation (#233)

adrianoc added 19 commits July 28, 2023 17:35
- use better label variable names for end of switch / each switch section
- does not emit a jump to the end of the switch at the last case before a 'default'
- adds individual switch sections to snippet / cecilified mapping
…ss value type instantiation (#243)

this uncovered a bunch of scenarios in which simple instantition of parameterless value type is not working. These will be fixed in a future commit and
handling of ObjectInitializerExpression for those in a follow up one
…n in tests accordingly

this issue was discovered while working on #243
- Microsoft.CodeAnalysis -> 4.7.0-2.final
- NUnit3TestAdapter -> 4.5.0
- Microsoft.NET.Test.Sdk -> 17.7.0
…void having 2 steps: create / add instruction, which makes the code less readable

also fixes test expectations
we moved to github actions about 5 months ago
this also fix a crash in the presence of unboxing operations
also updates some incorrect expectations related to the same issue
…odDefinitions (#245)

this was happening due a mismatch between the registering of the variable used to store the
MethodDefinition object and the query used to retrieve it back when processing references
to such method.
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 95.50% and no project coverage change.

Comparison is base (214eb89) 96.13% compared to head (f5dfb34) 96.14%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #252   +/-   ##
=======================================
  Coverage   96.13%   96.14%           
=======================================
  Files          76       77    +1     
  Lines        6655     6714   +59     
=======================================
+ Hits         6398     6455   +57     
- Misses        257      259    +2     
Files Changed Coverage Δ
Cecilifier.Core/TypeSystem/RoslynTypeSystem.cs 98.07% <50.00%> (-1.93%) ⬇️
Cecilifier.Core/TypeSystem/SystemTypeSystem.cs 96.66% <50.00%> (-3.34%) ⬇️
Cecilifier.Core/AST/StatementVisitor.cs 95.65% <94.11%> (-0.26%) ⬇️
...cilifier.Core/AST/ExpressionVisitor.Conversions.cs 94.44% <94.44%> (ø)
...er.Core/AST/ValueTypeNoArgCtorInvocationVisitor.cs 96.96% <97.14%> (-0.22%) ⬇️
Cecilifier.Core/AST/AssignmentVisitor.cs 97.72% <100.00%> (+0.03%) ⬆️
Cecilifier.Core/AST/ExpressionVisitor.cs 96.04% <100.00%> (+0.21%) ⬆️
Cecilifier.Core/AST/MethodDeclarationVisitor.cs 99.33% <100.00%> (ø)
...oArgsValueTypeObjectCreatingInAssignmentVisitor.cs 100.00% <100.00%> (ø)
Cecilifier.Core/AST/SyntaxWalkerBase.cs 96.95% <100.00%> (-0.03%) ⬇️
... and 3 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adrianoc adrianoc marked this pull request as ready for review August 18, 2023 13:51
@adrianoc adrianoc merged commit 6e47175 into main Aug 18, 2023
@adrianoc adrianoc deleted the vnext branch August 18, 2023 13:51
@adrianoc adrianoc mentioned this pull request Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants