Cleanups #176
Open
Cleanups #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pabs3
commented
Sep 4, 2023
pabs3
commented
- Fix compiler warning about incorrect printf specifier
- Fix memory leaks
- Add missing va_end() calls
- Clean up curses terminal resources on exit
- Avoid reading uninitialised memory
- Fix formatting of manual page items
- Fix typos
- Drop unnecessary paragraph indicators in the manual pages
- Wrap long lines in the manual pages
- Remove trailing whitespace
The variable is a size_t but the z printf length modifier is missing. Suggested-by: gcc -Wformat
Suggested-by: cppcheck
Suggested-by: cppcheck
Suggested-by: valgrind
This can cause crashes when the memory contains previous data. Suggested-by: glibc MALLOC_CHECK_=2 & valgrind
Suggested-by: mandoc -T lint
Suggested-by: mandoc -T lint
Suggested-by: mandoc -T lint
Suggested-by: nano, git, mandoc -T lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.