Use XXH64 instead of MD5 #108
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bebehei
reviewed
Jun 11, 2018
| @@ -0,0 +1,3 @@ | |||
| [submodule "xxHash"] | |||
There was a problem hiding this comment.
You're changing the build instructions here. It's not possible to just do a normal clone of the repo and fire a make call anymore.
Looking at the current master, It's general not a good advice having no build instructions at all. But you're introducing a stupid trap door here, which warrants a comment a.k.a. build documentation.
While reading the XXH64 website, it looks pretty promising.
|
I'm running on an ARM based system where cpu counts. Can you rebase this PR ? |
|
Didn't seem like a whole lot of interest to have it merged. |
|
Rebasing would be better so it if works fine we can ask for a merge ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switching to a more CPU friendly hash algorithm that is 100x faster than MD5.
Both XXH64 and MD5 have quality index of 10 in SMHasher.
Also confirmmatch() is run prior to erasure.