-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REF: Split up tests into modules & remove redundant testing #56
Conversation
adriangb
commented
Aug 15, 2020
•
edited
Loading
edited
- Split up tests into multiple modules
- Implement scikit-learn estimator checks on non-subclassed estimators
- Remove redundant tests and test parametrizations.
- Fix TST: Inconsistent failing for TestSampleWeights #43 by implementing a much better test.
- If pytest-xdist fails on CI, still fail the run but also try to run tests without xdist to get clean debugging info.
…r checks on non-subclassed estimators, remove redundant tests and test parametrizations.
Codecov Report
@@ Coverage Diff @@
## master #56 +/- ##
==========================================
- Coverage 99.51% 99.51% -0.01%
==========================================
Files 3 3
Lines 415 413 -2
==========================================
- Hits 413 411 -2
Misses 2 2
Continue to review full report at Codecov.
|
], | ||
ids=["KerasClassifier", "KerasRegressor"], | ||
) | ||
def test_fully_compliant_estimators(estimator, check): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stsievert I know we went back and forth on checking that non-subclassed models can pass all tests. Here is proof that they do. As you suggested, the only test they fail is check_no_attributes_set_in_init
. I added a separate tests specifically for that below.