Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REF: Split up tests into modules & remove redundant testing #56

Merged
merged 9 commits into from
Aug 15, 2020

Conversation

adriangb
Copy link
Owner

@adriangb adriangb commented Aug 15, 2020

  • Split up tests into multiple modules
  • Implement scikit-learn estimator checks on non-subclassed estimators
  • Remove redundant tests and test parametrizations.
  • Fix TST: Inconsistent failing for TestSampleWeights #43 by implementing a much better test.
  • If pytest-xdist fails on CI, still fail the run but also try to run tests without xdist to get clean debugging info.

…r checks on non-subclassed estimators, remove redundant tests and test parametrizations.
@codecov-commenter
Copy link

codecov-commenter commented Aug 15, 2020

Codecov Report

Merging #56 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #56      +/-   ##
==========================================
- Coverage   99.51%   99.51%   -0.01%     
==========================================
  Files           3        3              
  Lines         415      413       -2     
==========================================
- Hits          413      411       -2     
  Misses          2        2              
Impacted Files Coverage Δ
scikeras/wrappers.py 99.70% <ø> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27a1a2d...e2bf20f. Read the comment docs.

],
ids=["KerasClassifier", "KerasRegressor"],
)
def test_fully_compliant_estimators(estimator, check):
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stsievert I know we went back and forth on checking that non-subclassed models can pass all tests. Here is proof that they do. As you suggested, the only test they fail is check_no_attributes_set_in_init. I added a separate tests specifically for that below.

@adriangb adriangb merged commit cf7ea78 into master Aug 15, 2020
@adriangb adriangb deleted the test-modularize branch August 15, 2020 21:08
@adriangb adriangb mentioned this pull request Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TST: Inconsistent failing for TestSampleWeights
2 participants