Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecation warning for **kwargs and support them in partial_fit #238

Merged
merged 4 commits into from
Aug 2, 2021

Conversation

adriangb
Copy link
Owner

@adriangb adriangb commented Aug 1, 2021

Closes #236. Closes #131 .

@codecov-commenter
Copy link

codecov-commenter commented Aug 1, 2021

Codecov Report

Merging #238 (251b625) into master (cd845db) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #238      +/-   ##
==========================================
- Coverage   98.90%   98.90%   -0.01%     
==========================================
  Files           6        6              
  Lines         733      730       -3     
==========================================
- Hits          725      722       -3     
  Misses          8        8              
Impacted Files Coverage Δ
scikeras/wrappers.py 97.98% <100.00%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd845db...251b625. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Aug 1, 2021

📝 Docs preview for commit 251b625 at: https://www.adriangb.com/scikeras/refs/pull/238/merge/

@adriangb
Copy link
Owner Author

adriangb commented Aug 2, 2021

Nightly tests seem to be failing on all branches. I'll look into that separately.

@adriangb adriangb merged commit 86093c4 into master Aug 2, 2021
@adriangb adriangb deleted the kwargs branch August 2, 2021 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't pickle trained model with callback to TensorBoard validation_data parameter to fit with preprocessing
2 participants