Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fix multiclass onehot inverse #189

Merged
merged 12 commits into from
Feb 15, 2021
Merged

Conversation

adriangb
Copy link
Owner

Resolves #188

One-hot encoded targets were not being processed correctly. The tests were checking for shapes and dtypes (which were correct), but the values were not.

This implements 2 things:

  • 2 line fix for the bug in transformers.py
  • Extensive test refactoring to test for estimator scores (to prevent this bug in the future).

@github-actions
Copy link

github-actions bot commented Feb 15, 2021

📝 Docs preview for commit f197d94 at: https://www.adriangb.com/scikeras/refs/pull/189/merge/

scikeras/wrappers.py Outdated Show resolved Hide resolved
scikeras/wrappers.py Outdated Show resolved Hide resolved
scikeras/utils/transformers.py Outdated Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Feb 15, 2021

Codecov Report

Merging #189 (f197d94) into master (374b436) will increase coverage by 0.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #189      +/-   ##
==========================================
+ Coverage   99.55%   99.70%   +0.14%     
==========================================
  Files           6        6              
  Lines         671      669       -2     
==========================================
- Hits          668      667       -1     
+ Misses          3        2       -1     
Impacted Files Coverage Δ
scikeras/wrappers.py 99.43% <ø> (ø)
scikeras/utils/transformers.py 100.00% <100.00%> (+0.93%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 374b436...f197d94. Read the comment docs.

@adriangb adriangb mentioned this pull request Feb 15, 2021
@adriangb
Copy link
Owner Author

#188 (comment) confirms this fixes the original bug report. Will move forward with merge.

@adriangb adriangb merged commit e36f03f into master Feb 15, 2021
@adriangb adriangb deleted the fix-multiclass-onehot-inverse branch February 15, 2021 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with model setup
3 participants