Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: fix signature of BaseWrapper.scorer #169

Merged
merged 1 commit into from
Jan 17, 2021
Merged

Conversation

adriangb
Copy link
Owner

Closes #168

@codecov-io
Copy link

codecov-io commented Jan 17, 2021

Codecov Report

Merging #169 (fc72b40) into master (312b144) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #169   +/-   ##
=======================================
  Coverage   99.55%   99.55%           
=======================================
  Files           6        6           
  Lines         679      679           
=======================================
  Hits          676      676           
  Misses          3        3           
Impacted Files Coverage Δ
scikeras/wrappers.py 99.44% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 312b144...fc72b40. Read the comment docs.

@adriangb adriangb merged commit 9d64acf into master Jan 17, 2021
@adriangb adriangb deleted the fix-scorer-signature branch January 17, 2021 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scorer in BaseWrapper should accept y_true and y_pred instead of X and y
2 participants