Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: fix the initialize method for KerasClassifier #140

Merged
merged 2 commits into from
Nov 29, 2020

Conversation

adriangb
Copy link
Owner

@adriangb adriangb commented Nov 29, 2020

Overrides initialize in KerasClassifier to properly handle the classes param of partial_fit.

@codecov-io
Copy link

codecov-io commented Nov 29, 2020

Codecov Report

Merging #140 (649ac13) into master (94960da) will increase coverage by 0.17%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #140      +/-   ##
==========================================
+ Coverage   99.33%   99.50%   +0.17%     
==========================================
  Files           5        5              
  Lines         599      609      +10     
==========================================
+ Hits          595      606      +11     
+ Misses          4        3       -1     
Impacted Files Coverage Δ
scikeras/utils/transformers.py 100.00% <100.00%> (ø)
scikeras/wrappers.py 99.15% <100.00%> (+0.30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94960da...649ac13. Read the comment docs.

@adriangb adriangb merged commit aa41b55 into master Nov 29, 2020
@adriangb adriangb deleted the fix-initialize-kerasclassifier branch November 29, 2020 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants