Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC-194 Example with versioning and how it works. #353

Merged
merged 3 commits into from
Oct 15, 2024

Conversation

Motouom
Copy link
Collaborator

@Motouom Motouom commented Sep 25, 2024

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.79%. Comparing base (f195bcd) to head (ab1bd35).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #353   +/-   ##
==========================================
  Coverage      86.79%   86.79%           
  Complexity         1        1           
==========================================
  Files            164      164           
  Lines           3354     3354           
  Branches         217      217           
==========================================
  Hits            2911     2911           
  Misses           309      309           
  Partials         134      134           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@francis-pouatcha francis-pouatcha linked an issue Sep 26, 2024 that may be closed by this pull request
@francis-pouatcha francis-pouatcha linked an issue Sep 26, 2024 that may be closed by this pull request
Copy link
Collaborator

@AssahBismarkabah AssahBismarkabah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hello @Motouom
i guess this doc on example with versioning has been described already in the https://github.com/adorsys/datasafe/blob/develop/docs/readme/HowItWorks.md you could include the modifications directly and add the test for the example with unencrypted path

@Motouom
Copy link
Collaborator Author

Motouom commented Oct 4, 2024

hello @Motouom i guess this doc on example with versioning has been described already in the https://github.com/adorsys/datasafe/blob/develop/docs/readme/HowItWorks.md you could include the modifications directly and add the test for the example with unencrypted path

@AssahBismarkabah that documentation provides an overview of the Datasafe project, but when going specific mise, I prefer to do it in a different file, since it describes something specific.

Copy link
Collaborator

@AssahBismarkabah AssahBismarkabah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok @Motouom then just include the example with unencrpted path as it is included in the documentation

Copy link

sonarcloud bot commented Oct 10, 2024

@AssahBismarkabah AssahBismarkabah merged commit 5333827 into adorsys:develop Oct 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Example with versioning
2 participants