-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC-194 Example with versioning and how it works. #353
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #353 +/- ##
==========================================
Coverage 86.79% 86.79%
Complexity 1 1
==========================================
Files 164 164
Lines 3354 3354
Branches 217 217
==========================================
Hits 2911 2911
Misses 309 309
Partials 134 134 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hello @Motouom
i guess this doc on example with versioning has been described already in the https://github.com/adorsys/datasafe/blob/develop/docs/readme/HowItWorks.md you could include the modifications directly and add the test for the example with unencrypted path
@AssahBismarkabah that documentation provides an overview of the Datasafe project, but when going specific mise, I prefer to do it in a different file, since it describes something specific. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok @Motouom then just include the example with unencrpted path
as it is included in the documentation
Quality Gate passedIssues Measures |
@max402 @francis-pouatcha @AssahBismarkabah please review my PR